Fix(logging): Include status code in GitHubClient logResponse - #2321
Open
vyckou wants to merge 1 commit into
Open
Fix(logging): Include status code in GitHubClient logResponse#2321vyckou wants to merge 1 commit into
vyckou wants to merge 1 commit into
Conversation
When logging is set to FINER on org.kohsuke.github.GitHubClient class, expected behavior should be ``` FINE (2a8c) GitHub API request: GET https://api.github.com/repos/my-org/my-repo/pulls/123 FINER (2a8c) GitHub API response: https://api.github.com/repos/my-org/my-repo/pulls/123 200 ``` but instead we are getting ``` FINE (2a8c) GitHub API request: GET https://api.github.com/repos/my-org/my-repo/pulls/123 FINER (2a8c) GitHub API response: https://api.github.com/repos/my-org/my-repo/pulls/123 ``` response log line silently eats up response status code
vyckou
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2321 +/- ##
=========================================
Coverage 85.41% 85.41%
Complexity 2568 2568
=========================================
Files 242 242
Lines 7577 7577
Branches 399 399
=========================================
Hits 6472 6472
Misses 869 869
Partials 236 236 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vyckou
marked this pull request as ready for review
September 11, 2026 14:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When logging is set to FINER on GitHubClient class, expected behavior should be
but instead we are getting
response log line silently eats up response status code